Skip to content

tokenize_verilog: tokens can have a sign in general#13

Open
sebastianst wants to merge 1 commit intoencryptogroup:masterfrom
sebastianst:int-token
Open

tokenize_verilog: tokens can have a sign in general#13
sebastianst wants to merge 1 commit intoencryptogroup:masterfrom
sebastianst:int-token

Conversation

@sebastianst
Copy link
Copy Markdown

This function is used in ABY's BooleanCircuit::PutGateFromFile. Tokens, in general, can have a sign so I propose to change the type of tokens to int. Will also shortly post a respective PR in the ABY repo.

@sebastianst
Copy link
Copy Markdown
Author

Please merge or comment @lenerd

@lenerd
Copy link
Copy Markdown
Collaborator

lenerd commented Apr 7, 2021

What does a token actually represent (the naming is very generic), is it a wire id?
Maybe @dd23 should take a look at this.

@sebastianst
Copy link
Copy Markdown
Author

What does a token actually represent (the naming is very generic), is it a wire id?
Maybe @dd23 should take a look at this.

Yes, it's a wire id, so it could be allowed to be negative. It doesn't hurt to parse it as an int instead of just a uint. I had a case where I wrote a script that output a circuit with positive and negative wire ids (because it made more sense there) and this extension came in handy. I think I maybe marked the input wires negative...

@lenerd
Copy link
Copy Markdown
Collaborator

lenerd commented Apr 9, 2021

And these wire ids are not used as indices to an array anywhere?

@dd23
Copy link
Copy Markdown
Collaborator

dd23 commented Apr 11, 2021

Commented there: encryptogroup/ABY#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants