Include more flexible PythonEngine configuration variables#42
Open
tomac wants to merge 4 commits intoendgameinc:masterfrom
Open
Include more flexible PythonEngine configuration variables#42tomac wants to merge 4 commits intoendgameinc:masterfrom
tomac wants to merge 4 commits intoendgameinc:masterfrom
Conversation
rw-access
reviewed
Nov 11, 2020
Contributor
rw-access
left a comment
rw-access
left a comment
There was a problem hiding this comment.
overall looks good!
mind adding a unit test? might feel like overkill, but could help to make sure we don't add regressions in the future
Contributor
|
here's an example test that's similar: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
In order to be more flexible with the PythonEngine configuration options, it would be better to let users to define some internal keys and not being so endgame-centric :) Adding the option to change the process type, as well as the process subtype and create/termination event subtypes would be great.
Details
Describe details about your requested changes