fix: make feature flag disable_tenant idempotent to prevent 500 error#140
Open
fix: make feature flag disable_tenant idempotent to prevent 500 error#140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
set.remove()toset.discard()inFeatureFlag.disable_tenant()methodWhy
When toggling templates OFF in the admin panel for a tenant that never had templates enabled, the system
returned a 500 Internal Server Error.
Root cause:
set.remove(tenant_id)raisesKeyErrorif the tenant_id doesn't exist in the set. Usingset.discard()is the idempotent alternative that safely handles this case.This affects all users on the latest version who try to toggle templates when they were never enabled, or
toggle off twice in a row.
Testing
test_disable_tenant_is_idempotent- verifies disabling a never-enabled tenant doesn't crashtest_enable_tenant_is_idempotent- verifies enabling twice is safe