You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for digging into this and putting together a fix , it helped surface some deeper issues in how resource moving works.
Right now, move_collection_to_space calls import_group_to_space, which only links the knowledge to the target space rather than actually moving it. Switching to move_group_owner_to_space would move ownership, but
introduces other complications.
The core issue is that user_id on the collection never changes during a move. The original creator remains the owner even if they no longer have access to the target space, resulting in orphaned ownership and
unclear access patterns. The same applies to websites, where move_website_to_space explicitly does not change ownership either.
Given these open questions around ownership and access control, we're going to remove this functionality for now and revisit it once we have a clearer design in place. If there's a strong need for this, we'd appreciate proposals on how ownership transfer and access should be handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When moving a knowledge source between two shared spaces, it doesnt get moved when pressing move. This fixes the issue.