fix: reasoning_content AttributeError on non-reasoning models#338
Merged
MaxEriksson2000 merged 1 commit intodevelopfrom Apr 10, 2026
Merged
fix: reasoning_content AttributeError on non-reasoning models#338MaxEriksson2000 merged 1 commit intodevelopfrom
MaxEriksson2000 merged 1 commit intodevelopfrom
Conversation
The pyright strict hardening in #325 replaced hasattr() checks with direct attribute access, but the runtime Message object from the OpenAI SDK does not have reasoning_content on non-reasoning models, causing AttributeError and failing all app runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasattr(msg, "reasoning_content")with direct attribute accessmsg.reasoning_contentMessageobject from the OpenAI SDK doesn't have this attribute on non-reasoning models, causingAttributeErrorand failing all app runsgetattr(msg, "reasoning_content", None)for safe access