Changed visible=false to visible=true in Vine examples and added a li…#26
Open
markus-enklu wants to merge 1 commit intoreleasefrom
Open
Changed visible=false to visible=true in Vine examples and added a li…#26markus-enklu wants to merge 1 commit intoreleasefrom
markus-enklu wants to merge 1 commit intoreleasefrom
Conversation
…nk to the VineML page to make it immediately clear that there is more information on VineML available
ShannonKalei
suggested changes
Aug 2, 2021
Contributor
There was a problem hiding this comment.
Another one of those "who thought this was a good idea?" type examples 😅 But ty for fixing 🙏 Though now that I've actually looked at this, there's a lot more wrong with this example:
font.sizeshould befontSize- the
positionis set to +10 meters in the z direction, so you likely wouldn't even be able to see it visibilitydefaults totrue, so maybe we should just remove it entirely?widthalso seems like a weird addition since this example is just 1 word 🤔- Also, I'm pretty sure
<Caption>is an old version of<Text>. They are the same under the hood and the vines are still backwards compatible, but maybe we should swap this to<Text>since that's likely a clearer term than caption?
Contributor
|
Here is what I propose we change it to: <Text
label = 'Hello World'
fontSize = 100
fontColor = '#FFFF00'
width = 1000.5
alignment = 'MidCenter'
position = (0, 0.5, 0.5)
/>
|
AshleyAmazing
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
width=1000.5?
What a strange number, I wish we had more context for this number, is it based on screen size? The rest looks good to me. Text width defaults to 1500 but .5 of what a pixel? an em? a pt? I know it's a float but I wish it made more sense for text.
Also I agree with Shannon and recommend you add in those changes as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nk to the VineML page to make it immediately clear that there is more information on VineML available