Conversation
denizs
force-pushed
the
major/migrate-to-platform-apis
branch
2 times, most recently
from
9c8c207 to
9c3bb7c
Compare
this will serve as the unified ENLYZE platform API client
denizs
force-pushed
the
major/migrate-to-platform-apis
branch
from
9c3bb7c to
cd246ba
Compare
denizs
force-pushed
the
major/migrate-to-platform-apis
branch
from
cd246ba to
62bf4cd
Compare
Coverage resultsUpdate on 2025-05-05 14:38:06.962550955 +0000 This is the coverage report for commit 0c06385 |
denizs
commented
Aug 16, 2024
Member
Author
There was a problem hiding this comment.
This is the synthesis of the previously single client prior to the introduction of Production Runs.
denizs
requested review from
cipherself and
daniel-k
and removed request for
cipherself
daniel-k
requested changes
Aug 21, 2024
Member
daniel-k
left a comment
daniel-k
left a comment
There was a problem hiding this comment.
Haven't reviewed it yet, just noticed that coverage is missing for one line:
Name Stmts Miss Cover Missing
------------------------------------------------------------------------------------------------
.tox/py/lib/python3.12/site-packages/enlyze/api_client/client.py 64 1 98% 149
Closed
Co-authored-by: Daniel Krebs <daniel-k@users.noreply.github.com>
Co-authored-by: Daniel Krebs <daniel-k@users.noreply.github.com>
when this PR was submitted, the production run's machine field used to be an expanded subset of the machines endpoint featuring the machine's uuid and name field. After our refactor to a uuid reference of `machine`, MachineBase has become obsolete.
daniel-k
requested changes
May 5, 2025
Member
daniel-k
left a comment
daniel-k
left a comment
There was a problem hiding this comment.
Thank you for addressing my comments so far. What about these two?
daniel-k
approved these changes
May 5, 2025
denizs
added a commit
that referenced
this pull request
May 5, 2025
This was referenced May 13, 2025
Merged
daniel-k
added a commit
that referenced
this pull request
May 13, 2025
This PR fixes issues we overlooked when merging #47. It depends on #54 so that we can review the fixes in isolation and don't get distracted with code that has already been approved. - remove `Site.address`: we don't publish this property anymore since `v2` - refactor `get_timeseries()` to use `POST` with slightly changed schema in `v2` Closes #45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the project to our new unified platform APIs hosted under
/api/v2, byBearer(fromToken)Sites to uuidsMoreover, this PR fixes a bug in
datetime_before_today_strategythat caused flaky test results.How to review
Commit by commit. I've done my best to keep commits atomic and semantic.
Closes
/api/v2#45