Open
Conversation
This adds support to the `.post()` method to only post the timer if it doesn't already exist. This is useful for implementing application logic where the timer must fire after `delay` milliseconds, or sooner if the timer was already set (the current behaviour is to always overwrite and extend the timer).
I had the 'NX' option in the wrong place, so that was not working at all. I've also broken out the logic for overwriting the delay time and overwriting the actual message into two separate options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to the
.post()method to only post the timer if itdoesn't already exist. This is useful for implementing application
logic where the timer must fire after
delaymilliseconds, or sooner ifthe timer was already set (the current behaviour is to always overwrite
and extend the timer). I've added a new parameter, but maintained
backwards compatibility.
I'm using this in my app because I needed it. I don't have any tests,
but thought you might like to consider it anyway.