Open
Conversation
Contributor
Matrix buildsGreat work so far! By targeting specific versions of Node, we've configured a build matrix which allow us to test across multiple operating systems, platforms, and language versions. See Configuring a matrix build in GitHub Help if you'd like to learn more. I'll respond when you commit the changes in the comment below. |
| strategy: | ||
| matrix: | ||
| node-version: [12.x, 14.x, 16.x] | ||
| node-version: [16.x] |
Contributor
There was a problem hiding this comment.
Step 8: Target a Windows environment
Since we'd like to support deploying our app to Windows environments, let's add Windows to the matrix build configuration.
⌨️ Activity: Edit your workflow file to build for Windows environments
You can follow the suggestion, or manually make the changes in the numbered instructions.
Suggested change
| node-version: [16.x] | |
| os: [ubuntu-latest, windows-2016] | |
| node-version: [12.x, 14.x] |
- Edit the workflow config at
.github/workflows/nodejs.yml - Add an
osfield to thestrategy.matrixsection of your workflow - Add
ubuntu-latestandwindows-2016to the target operating systems - Commit your workflow changes to this branch.
I'll respond in this pull request when you've committed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.