Skip to content

Improve CI#8

Open
enriquehp06 wants to merge 1 commit intomainfrom
enriquehp06-patch-5
Open

Improve CI#8
enriquehp06 wants to merge 1 commit intomainfrom
enriquehp06-patch-5

Conversation

@enriquehp06
Copy link
Copy Markdown
Owner

No description provided.

@github-learning-lab
Copy link
Copy Markdown
Contributor

Matrix builds

Great work so far! By targeting specific versions of Node, we've configured a build matrix which allow us to test across multiple operating systems, platforms, and language versions. See Configuring a matrix build in GitHub Help if you'd like to learn more.

I'll respond when you commit the changes in the comment below.

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
node-version: [16.x]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 8: Target a Windows environment

Since we'd like to support deploying our app to Windows environments, let's add Windows to the matrix build configuration.

⌨️ Activity: Edit your workflow file to build for Windows environments

an icon of three gears

You can follow the suggestion, or manually make the changes in the numbered instructions.

Suggested change
node-version: [16.x]
os: [ubuntu-latest, windows-2016]
node-version: [12.x, 14.x]
  1. Edit the workflow config at .github/workflows/nodejs.yml
  2. Add an os field to the strategy.matrix section of your workflow
  3. Add ubuntu-latest and windows-2016 to the target operating systems
  4. Commit your workflow changes to this branch.

I'll respond in this pull request when you've committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant