Skip to content

perf(entgql): avoid COUNT(*) for pageInfo-only connection queries #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tutranngoc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf(entgql): avoid COUNT(*) for pageInfo-only connection queries #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions entgql/internal/todo/ent/gql_pagination.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions entgql/internal/todofed/ent/gql_pagination.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions entgql/internal/todoglobalid/ent/gql_pagination.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions entgql/internal/todogotype/ent/gql_pagination.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions entgql/internal/todopulid/ent/gql_pagination.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions entgql/internal/todouuid/ent/gql_pagination.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion entgql/template/pagination.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ func ({{ $r }} *{{ $name }}) ToEdge(order *{{ $order }}) *{{ $edge }} {
{{- /* Ensure the "edges" field is marshaled as "[]" in case it is empty. */}}
conn := &{{ $conn }}{Edges: []*{{ $edge }}{}}
ignoredEdges := !hasCollectedField(ctx, edgesField)
if hasCollectedField(ctx, totalCountField) || hasCollectedField(ctx, pageInfoField) {
if hasCollectedField(ctx, totalCountField) {
hasPagination := after != nil || first != nil || before != nil || last != nil
if hasPagination || ignoredEdges {
c := {{ $r }}.Clone()
Expand Down
Loading