Allow the definition of the _midlSAFEARRAY(HRESULT) type.

[davidschranz]

Pull request for changes described in #668

[junkmd]

Thank you for contributing.

We need to write test code as well.

The test will include assertions ensuring that the definition of _midlSAFEARRAY(HRESULT) does not cause an error, while calling _midlSAFEARRAY(HRESULT).create raises a TypeError.

There are multiple modules for testing safearray, so I am currently looking for the most appropriate place to add the test.

[junkmd]

Formatting issue.

-                    )
+                )

[junkmd]

I believe that test/test_midl_safearray_create.py is the most suitable location to test this behavior.

You could add a test like the following:

comtypes/comtypes/test/test_midl_safearray_create.py

Lines 1 to 4 in fb15f91

	# coding: utf-8
	from ctypes import c_int, pointer, POINTER
	import unittest

 # coding: utf-8

-from ctypes import c_int, pointer, POINTER
+from ctypes import c_int, pointer, HRESULT, POINTER
 import unittest

comtypes/comtypes/test/test_midl_safearray_create.py

Lines 82 to 87 in fb15f91

	self.assertEqual(unpacked.answer, 42)
	self.assertEqual(unpacked.needs_clarification, True)
	def test_ctype(self):
	extra = None
	cdata = c_int(1)

                 self.assertEqual(unpacked.answer, 42)
                 self.assertEqual(unpacked.needs_clarification, True)

+    def test_HRESULT(self):
+        hr = HRESULT(1)
+        sa_type = comtypes.safearray._midlSAFEARRAY(HRESULT)
+        with self.assertRaises(TypeError):
+            sa_type.create([hr], extra=None)
+        with self.assertRaises(TypeError):
+            sa_type.create([hr])
+
     def test_ctype(self):
         extra = None
         cdata = c_int(1)

[junkmd]

Thanks.

[davidschranz]

Thank you very much for your help!

[junkmd]

You're welcome.
This time, the changes to the production code were minimal, and the tests were also kept to a minimum.
Above all, your excellent reproducer and your responsiveness when I asked for verification made this PR much easier to merge.