-
-
Notifications
You must be signed in to change notification settings - Fork 104
Modernize npsupport by removing the patch for the np._typecodes.
#857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize npsupport by removing the patch for the np._typecodes.
#857
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
==========================================
- Coverage 84.75% 84.74% -0.01%
==========================================
Files 125 125
Lines 11571 11566 -5
==========================================
- Hits 9807 9802 -5
Misses 1764 1764 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
26122b2 to
3f47e0a
Compare
VT_I4 ndarray creation with explicitly specifying dtype=numpy.int32.npsupport.
7db5339 to
a5f6c25
Compare
ece1978 to
9887a10
Compare
|
This PR focuses solely on removing the patch for the To verify that the mapping elements remain unchanged, simply run the following in interactive mode both before and after code modifications. |
npsupport.npsupport by removing the patch for the np._typecodes.
Rename from `_check_ctypeslib_typecodes` to `_build_typecodes` for clarity.
Remove overwriting `ctypeslib._typecodes` because `_typecodes` was removed in `numpy==1.16` (`numpy` supporting Python3.8 is `1.17` and above).
9887a10 to
514f052
Compare
|
Codecov observed only a -0.01% decrease in coverage with this change. 514f052 |
Fixes #858