Revive util and add comprehensive tests.
#865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a basic import test for the `comtypes.util` module to ensure it can be imported without errors. This serves as a foundational test for future enhancements.
Fixes a `RuntimeError` in `comtypes.util._calc_offset` that occurred due to a type mismatch when validating `PyCArgObject`. The `argobj.tag` field, which is a `c_char`, is represented as a `bytes` object in Python (e.g., `b'P'`). However, the validation logic was comparing it to a `str` literal (`"P"`). This comparison always failed, leading to an incorrect `RuntimeError` being raised. This fix changes the literal to `b"P"`, ensuring the comparison is performed correctly between two `bytes` objects. This resolves the underlying issue and allows `_calc_offset` to function as intended.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
==========================================
+ Coverage 84.39% 84.73% +0.33%
==========================================
Files 124 125 +1
Lines 11442 11559 +117
==========================================
+ Hits 9657 9795 +138
+ Misses 1785 1764 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445.
Revives the
utilmodule by fixing a critical bug, and introduces a comprehensive test suite.The
utilmodule provides essential helper functions for advanced COM interoperability, but it has lacked dedicated tests.Fixing a
RuntimeErrorin_calc_offsetThe function was incorrectly comparing the
PyCArgObject.tag(abytesliteral,b'P') with astrliteral ("P"), causing the validation to fail and aRuntimeErrorto be raised.This has been corrected by changing the literal to
b'P', allowing the function to work as intended.Adding comprehensive tests for
utilfunctionsbyref_atTests now cover basic ctypes, array offsets, pointer arithmetic simulation, COM interfaces, large offsets, and memory safety.
cast_fieldTests validate behavior with basic ctypes, type reinterpretation, pointers, nested structures/unions, arrays, and v-table-like structures.