Refactor and enhance util with explicit imports and typing.
#866
+37
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are no longer needed since the wildcard import was replaced by explicit imports.
Removes several parameters from the `cast_field` function signature that were no longer being used.
junkmd
added
typing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
+ Coverage 84.73% 84.75% +0.01%
==========================================
Files 125 125
Lines 11559 11571 +12
==========================================
+ Hits 9795 9807 +12
Misses 1764 1764 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
junkmd
added a commit
to junkmd/comtypes
that referenced
this pull request
Jul 21, 2025
…ght#866) * Use explicit imports in `util`. * Remove unnecessary ruff ignores for `util.py`. These are no longer needed since the wildcard import was replaced by explicit imports. * Remove unused parameters from `cast_field`. Removes several parameters from the `cast_field` function signature that were no longer being used. * Add overloads to `util.byref_at` for improved type hinting. * Add overloads to `util.cast_field` for improved type hinting. * Replace `Type[_SimpleCData[_T]]` with `Type["_SimpleCData[_T]"]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements to the
utilmodule, focusing on modernizing the code.Key Changes:
Explicit imports
Replaces the wildcard import (
from ctypes import *) with explicit imports.Improved type hinting
Adds
typing.overloadtobyref_atandcast_field.Code cleanup
Removes several unused parameters from the
cast_fieldfunction, simplifying its signature.Removes the corresponding
F403andF405ignore rules frompyproject.tomlnow that wildcard imports are no longer used inutil.py.