Update hints.pyi and the type symbols under TYPE_CHECKING blocks in the generated codebase for PEP585 compliance.
#877
+25
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove conditional import of `Annotated` from `typing_extensions`. `Annotated` is available in the standard `typing` module since Python 3.9.
Remove unused import of `typing.Tuple` and replace `hints.Tuple` with the built-in `tuple` for type annotations in `typeannotator.py`. This simplifies type hinting and aligns with standard Python practices.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
=======================================
Coverage 84.70% 84.70%
=======================================
Files 125 125
Lines 11536 11536
=======================================
Hits 9771 9771
Misses 1765 1765 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #876.
As they have the smallest impact on the runtime codebase, I chose type stubs and symbols under
TYPE_CHECKINGblocks as the first step of #876.