Skip to content

Fix error message validation in test_puredispatch.py. #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junkmd merged 1 commit into from
Dec 28, 2025
Merged

Fix error message validation in test_puredispatch.py. #891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions comtypes/test/test_puredispatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import re
import unittest as ut
import winreg

Expand All @@ -12,6 +13,8 @@
HKCR = 0 # HKEY_CLASSES_ROOT
HKCU = 1 # HKEY_CURRENT_USER

NAMED_PARAM_ERRMSG = "named parameters not yet implemented"


class Test_Installer(ut.TestCase):
def test_registry_value_with_root_key_value(self):
Expand Down Expand Up @@ -58,20 +61,20 @@ def test_registry_value_with_named_params(self):
# if named arguments are passed to prevent invalid calls.
# TODO: After named parameters are supported, this will become a test to
# assert the return value.
ERRMSG = "named parameters not yet implemented"
with self.assertRaises(ValueError, msg=ERRMSG):
PTN = re.compile(rf"^{re.escape(NAMED_PARAM_ERRMSG)}$")
with self.assertRaisesRegex(ValueError, PTN):
inst.RegistryValue(Root=HKCR, Key=".txt", Value="") # type: ignore
with self.assertRaises(ValueError, msg=ERRMSG):
with self.assertRaisesRegex(ValueError, PTN):
inst.RegistryValue(Value="", Root=HKCR, Key=".txt") # type: ignore
with self.assertRaises(ValueError, msg=ERRMSG):
with self.assertRaisesRegex(ValueError, PTN):
inst.RegistryValue(HKCR, Key=".txt", Value="") # type: ignore
with self.assertRaises(ValueError, msg=ERRMSG):
with self.assertRaisesRegex(ValueError, PTN):
inst.RegistryValue(HKCR, ".txt", Value="") # type: ignore
with self.assertRaises(ValueError, msg=ERRMSG):
with self.assertRaisesRegex(ValueError, PTN):
inst.RegistryValue(Root=HKCU, Key=r"Control Panel\Desktop") # type: ignore
with self.assertRaises(ValueError, msg=ERRMSG):
with self.assertRaisesRegex(ValueError, PTN):
inst.RegistryValue(Key=r"Control Panel\Desktop", Root=HKCR) # type: ignore
with self.assertRaises(ValueError, msg=ERRMSG):
with self.assertRaisesRegex(ValueError, PTN):
inst.RegistryValue(HKCR, Key=r"Control Panel\Desktop") # type: ignore

def test_product_state(self):
Expand Down