Guard OpenCode session-start hook on duplicate session.created#824
Open
sanogueralorenzo wants to merge 3 commits intoentireio:mainfrom
Open
Guard OpenCode session-start hook on duplicate session.created#824sanogueralorenzo wants to merge 3 commits intoentireio:mainfrom
sanogueralorenzo wants to merge 3 commits intoentireio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session-starthook whensession.createdswitches to a different session idWhy
In the OpenCode plugin,
session.createdalready had a dedupe guard around the in-memory reset state (seenUserMessages,messageStore,currentModel), which means the code already expected the same session id to be observed more than once.Before this change,
session-startwas still fired unconditionally even when that guard did not pass. That created an asymmetric path where a duplicate or reactivation-stylesession.createdevent for the same session id would:session-startlifecycle event for that same sessionThat mismatch is not just cosmetic. On the CLI side,
session-startis consumed as a real lifecycle event and drivesEventSessionStarttransitions when session state already exists.Effect
With this change, OpenCode now treats duplicate
session.createdevents consistently:session-startsession.createdfor the current session id only refreshescurrentSessionIDand does not emit a duplicate lifecycle startThis keeps the plugin behavior aligned with its own dedupe guard and avoids re-firing session-start semantics for an already-tracked session.
Testing
go/miseare not installed in this environment)session-startinside thecurrentSessionID !== session.idguard