Allow setting of OperatorRef in Siri-SX subscription request#115
Open
leonardehrenfried wants to merge 2 commits intoentur:masterfrom
Open
Allow setting of OperatorRef in Siri-SX subscription request#115leonardehrenfried wants to merge 2 commits intoentur:masterfrom
leonardehrenfried wants to merge 2 commits intoentur:masterfrom
Conversation
Contributor
|
The original idea was that the subscription-config should use an enum-value from SubscriptionPreset, and that this enum would be processed in FilterMapPresets. Originally, this was done to support defining a list of filter-values - e.g. several lines like this case. I have not tested the code in this PR, but it looks like it works as expected, and it also seems like a more generic approach that will support most usecases. Could you also create an example for how this could be used to define a list of values in the subscriptions.yml-file? |
Contributor
Author
|
I would need to adjust the parsing code but I think it could work something like this: filterMap:
uk.org.siri.siri21.OperatorRefStructure:
- "AN_OPERATOR"
- "ANOTHER_OPERATOR"Do think that this kind of mechanism is a good idea or do we want something more workflow-specific like: operatorRef:
- "AN_OPERATOR"
- "ANOTHER_OPERATOR" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a Siri-SX subscription request I needed to set the
<OperatorRef>field.I found an example of how to do it in the Siri-ET code and tried to convert it to the Siri-SX one.
However, I'm not sure if I fully understood how these
filterMapsare supposed to be used.@lassetyr Can you check the config example if this is correct?