Skip to content

Legacy branch: Increase request-response max log statement size for GCP #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjolber merged 1 commit into from
Apr 30, 2026
Merged

Legacy branch: Increase request-response max log statement size for GCP #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .../src/main/java/no/entur/logging/cloud/spring/logbook/gcp/LogbookGcpAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ public class LogbookGcpAutoConfiguration {
@Bean
public LogbookLoggingCloudProperties logbookCloudConfiguration() {
LogbookLoggingCloudProperties c = new LogbookLoggingCloudProperties();
// subtract a few kb for headers and other wrapping
c.setMaxBodySize(131072 - 2 * 1024);
c.setMaxSize(131072);
// hard limit as of April 2026: 256 KiB - where KiB is 1024 bytes
// Body: set it to 224 KiB to be on the safe side,
// and to allow for a lot of overhead in the logging framework, MDC, HTTP headers, bytes vs chars, etc.
c.setMaxBodySize(229376);
c.setMaxSize(262144 - 2 * 1024); // inaccurate + currently not enforced
return c;
}
}
8 changes: 5 additions & 3 deletions ...cloud/gcp/spring/gcp/grpc/ecosystem/RequestResponseGcpGrpcEcosystemAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ public class RequestResponseGcpGrpcEcosystemAutoConfiguration {
@Bean
public GrpcLoggingCloudProperties grpcLoggingCloudProperties() {
GrpcLoggingCloudProperties c = new GrpcLoggingCloudProperties();
// subtract a few kb for headers and other wrapping
c.setMaxBodySize(131072 - 2 * 1024);
c.setMaxSize(131072);
// hard limit as of April 2026: 256 KiB - where KiB is 1024 bytes
// Body: set it to 224 KiB to be on the safe side,
// and to allow for a lot of overhead in the logging framework, MDC, HTTP headers, bytes vs chars, etc.
c.setMaxBodySize(229376);
c.setMaxSize(262144 - 2 * 1024); // inaccurate + currently not enforced
return c;
}
}
Loading