Skip to content

Use xfree over delete to be kinder to the ruby VM #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mariovisic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use xfree over delete to be kinder to the ruby VM #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/exiv2/exiv2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ extern "C" void Init_exiv2() {
// Exiv2::Image Methods

static void image_free(Exiv2::Image* image) {
delete image;
xfree(image);
Copy link
Contributor

@johnsyweb johnsyweb Dec 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't invoke Exiv2::Image's destructor, which, while currently empty may not always be.

}

static VALUE image_read_metadata(VALUE self) {
Expand Down