Skip to content

I needed to make this change to install this gem #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ostigley wants to merge 1 commit into from
Closed

I needed to make this change to install this gem #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ext/exiv2/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
require 'mkmf'

CONFIG['CXX'] = ENV['CXX'] || 'clang++'
Copy link
Contributor

@viraptor viraptor May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be solved on the user's system. I'd rather we did a check for CXX and fail loudly up front if it's not present.

Copy link
Contributor

@viraptor viraptor May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that with cxx.have_devel? it seems: https://github.com/ruby/ruby/blob/cbf9c088f8005a49b6aa3f475c70041357774c61/lib/mkmf.rb#L3022C9-L3022C20

Copy link
Author

@ostigley ostigley May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this will do to our ubuntu users (CMCG)

$CXXFLAGS += " -std=c++11"
RbConfig::CONFIG['PKG_CONFIG'] = 'pkg-config'

Expand All @@ -20,10 +21,10 @@
end

if have_macro("EXV_USE_CURL", "exiv2/exv_conf.h")
if dir_config("libcurl") == [nil, nil]
if dir_config("curl") == [nil, nil]
Copy link
Contributor

@viraptor viraptor May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only renames the flag --with-libcurl-dir to --with-curl-dir, but shouldn't affect compilation. Unless we have some really weird side effect here?

Copy link
Author

@ostigley ostigley May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given I've resolved my issues and all fingers are pointing to ruby-build, I'm happy to clsoe this PR

Copy link
Contributor

@viraptor viraptor May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about #34 instead?

pkg_config("libcurl")
end
have_library("libcurl")
have_library("curl")
end

create_makefile("exiv2/exiv2")