runtime: add new runtime guard for previous least request lb patch#30768
runtime: add new runtime guard for previous least request lb patch#30768wbpcode wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: wbpcode <wbphub@live.com>
|
cc @kyessenov |
|
Hah, forgot to check the ci after one busy day, sorry for that. Will check it tomorrow morning. |
| // Do full scan if it's required explicitly or the number of choices is equal to or larger than | ||
| // the hosts size. | ||
| if ((hosts_to_use.size() <= choice_count_) || enable_full_scan_) { | ||
| if ((full_scan_if_host_num_less_than_choice_num_ && hosts_to_use.size() <= choice_count_) || |
There was a problem hiding this comment.
Is there a reported issue for this, and what is the reason? Thanks!
There was a problem hiding this comment.
Issue for public reference: Istio disables cluster stats so it causes this PR to change load balancing to always pick the first host. Due to the DNS traffic concentration, there's some unexpected DNS failure as a result. We were not able to get Istio CI to deploy #29873, see istio/istio#47694.
There was a problem hiding this comment.
I think we can revert that PR temporarily until we figure out a new API for that. (Today is the last day that could do a break change to the API)
cc @kyessenov
There was a problem hiding this comment.
Yeap, let's do that, and then open it again with a safe default (e.g. by putting && instead of || when the flag is enabled).
4 participants
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]