Use set_hint('image-path', ...) in notification#141
Open
alexluigit wants to merge 1 commit intoeonpatapon:masterfrom
Open
Use set_hint('image-path', ...) in notification#141alexluigit wants to merge 1 commit intoeonpatapon:masterfrom
alexluigit wants to merge 1 commit intoeonpatapon:masterfrom
Conversation
So we can use 'uri' only for indicating playing state, and use 'image-path' for artUrl in notification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
For now it seems that we are using 'uri' for both playing state and artUrl. Use set_hint('image', ...) here will enable us use 'uri' only for indicating playing state, and 'artUrl' for cover image path in notification. Doing so we also get better looking cover in notification(at least bigger) and don't need that '(paused)' string anymore. What do you think?