Skip to content

NumericInput: add support for step="any" value #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akshayhat wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

NumericInput: add support for step="any" value #3012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions uui-components/src/inputs/NumericInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export interface NumericInputProps
downIcon?: Icon;

/** Increase/decrease step on up/down icons clicks and up/down arrow keys */
step?: number;
step?: number | 'any';

/** CSS classes to put directly on the Input element */
inputCx?: CX;
Expand Down Expand Up @@ -90,6 +90,7 @@ export const NumericInput = React.forwardRef<HTMLDivElement, NumericInputProps>(
const min = initialMin ?? 0;
const max = initialMax ?? Number.MAX_SAFE_INTEGER;
const formatOptions = initialFormatOptions ?? { maximumFractionDigits: 0 };
const stepValue = step === 'any' ? 1 : step ?? 1;

const placeholderValue = React.useMemo(() => {
if (typeof value === 'number') {
Expand Down Expand Up @@ -144,13 +145,13 @@ export const NumericInput = React.forwardRef<HTMLDivElement, NumericInputProps>(
};

const handleIncreaseValue = () => {
let newValue = getCalculatedValue({ value, step, action: 'incr' });
let newValue = getCalculatedValue({ value, step: stepValue, action: 'incr' });
newValue = getMinMaxValidatedValue({ value: newValue, min, max });
props.onValueChange(newValue);
};

const handleDecreaseValue = () => {
let newValue = getCalculatedValue({ value, step, action: 'decr' });
let newValue = getCalculatedValue({ value, step: stepValue, action: 'decr' });
newValue = getMinMaxValidatedValue({ value: newValue, min, max });
props.onValueChange(newValue);
};
Expand Down Expand Up @@ -227,7 +228,7 @@ export const NumericInput = React.forwardRef<HTMLDivElement, NumericInputProps>(
onBlur={ handleBlur }
min={ min }
max={ max }
step={ step || 'any' }
step={ step === undefined ? 'any' : step }
id={ props.id }
ref={ inputRef }
/>
Expand Down