-
Notifications
You must be signed in to change notification settings - Fork 3
Improve ImageRead widget formatting #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 91.12% 91.20% +0.07%
==========================================
Files 23 23
Lines 1465 1523 +58
==========================================
+ Hits 1335 1389 +54
- Misses 130 134 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This currently only converts ImageReads at the root of a screen. I think if you move the conversion into generate_component_formatters it should work in groups as well. |
|
WIP, there are customisation options like enabling color_bars that I'm not sure if they should belong to the dls.bob template (and parsed by the WidgetFormatter) or should be widget options (so FastCS can set them). I also changed an inconsistency about whether subscreen buttons have labels in groups or outside of groups, not sure which is preferred. |
|
I wonder can have option B, but with some kind of "open on new screen" icon as the button text? This is the best icon I could find... (D050000L font @coretl ? |
|
I think that icon is good. I have no strong opinion between A and B, but I'd like to see that icon at the end of any button text that launches a new screen |
|
I don't think the label text can be the signal name + the icon on the end because to get that icon you have to set the button label font to one that is all just icons. For now I suggest we go with B and the duplicated label and make a new Issue to use that icon for all buttons that open sub screens. |
3f5d2d7 to
bdf9dd9
Compare
get image widget width and height from widget dataclass
Regenerate test files. Includes some changes from previous commits.
1081904 to
010f326
Compare
|
I have tested this with fastcs-eiger using the pva transport and it works nicely for the monitor stream. I haven't tested the array trace, we can use CatIO to try this but I am going to merge this for now. |
Sounds good, I tested this previously with live PVs with a branch of FastCS, will give it a try now |





Closes #74
Works, will work on improving how to configure the size of the image widget.