Refactor the DataElement* class into Node and Leaf
#195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Everything works for me using open62541 v1.3.15 and EPICS base R7.0.6 - R7.0.9 on Linux and Windows. |
Contributor
|
Some more include cleanups are possible. Splitting the code created some duplication. |
ralphlange
force-pushed
the
refactor-element-tree
branch
2 times, most recently
from
63fc83d to
5332acf
Compare
ralphlange
force-pushed
the
refactor-element-tree
branch
from
8db8377 to
843b5c2
Compare
- Create `DataElement*Node` and `DataElement*Leaf` classes, make `DataElement*` an abstract base class - Move logic for handling structures to `DataElement*Node`, for data access to `DataElement*Leaf` - Update `ElementTree` to handle the new hierarchy - Update `ElementTreeTest` in unit tests - Clean up includes - make for-range loops use 'const auto &it' where possible
- merge branch 'dirk-zimoch/refactor-element-tree' - more fixes - compiles against UASDK 1.7.4, open62541 1.3.16 and 1.2.10
ralphlange
force-pushed
the
refactor-element-tree
branch
from
843b5c2 to
f193438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataElement*NodeandDataElement*Leafclasses, makeDataElement*an abstract base classDataElement*Node, for data access toDataElement*LeafElementTreeto handle the new hierarchyElementTreeTestin unit tests