Merged
Conversation
der
approved these changes
Nov 27, 2025
Member
der
left a comment
der
left a comment
There was a problem hiding this comment.
Looks good, thanks!
QUESTION: Should we further bump to Jakarta EE 11? This would mean going to servlet-api 6.1 and jersey 4 which I did do for ELDA, but there might be more far-reaching implications here?
I'd rather stick to 3.1.11 for now. I've had to downgrade Elda to 3.1.1 for compatibility with lib and still have problems getting it running, so prefer to hold off going to 4 here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JVM 1.8 -> 21
appbase 3.1.14 -> 4.0.0-SNAPSHOT
javax.servlet-api 3.1.0 -> jakarta.servlet-api 6.0.0
jersey-container-servlet 2.47 -> 3.1.11
Add logback-classic as logging provider
Update imports for javax -> jakarta migration
Replace use of StringBuffer with StringBuilder
Tidy-up source file formatting
QUESTION: Should we further bump to Jakarta EE 11? This would mean going to servlet-api 6.1 and jersey 4 which I did do for ELDA, but there might be more far-reaching implications here?