Fetch with variation option #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR expands the GraphClient API to support variations filtering when fetching content, transitioning from basic path-based filtering to more flexible content query options. It introduces a dedicated filters.ts module for building GraphQL query parameters and refactors the existing filtering functions.
- Refactors
fetchContentandfetchContentTypemethods to accept either a string path or options object with path and variation parameters - Creates new internal
filters.tsmodule with type-safe GraphQL query building utilities - Updates GraphQL queries to support variation parameters alongside existing where clauses
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/nextjs-template/src/app/json/[...slug]/page.tsx | Updates sample code to use simplified fetchContentType API without explicit filter |
| packages/optimizely-cms-sdk/src/index.ts | Removes getFilterFromPath from public exports |
| packages/optimizely-cms-sdk/src/graph/index.ts | Refactors GraphClient methods and removes deprecated filter functions |
| packages/optimizely-cms-sdk/src/graph/filters.ts | Adds new module with GraphQL query building utilities and TypeScript definitions |
| packages/optimizely-cms-sdk/src/graph/error.ts | Updates error types to use new ContentInput interface |
| packages/optimizely-cms-sdk/src/graph/createQuery.ts | Updates GraphQL query template to support variation parameters |
TRomesh
reviewed
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the
GraphClient.fetchContentmethod to allow path and variation as filter.As a refactor, introduces a new internal
filters.tsmodule with type definitions and utility functions (pathFilter,previewFilter,variationsFilter) for building GraphQL query filters, including support for variations and preview parameters.