Skip to content

Some fixes which I discovered on course of testing with Std. Test Harness #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kukrejaankit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Some fixes which I discovered on course of testing with Std. Test Harness #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions oadrlib/lib/oadr2b/RegisterReport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,15 @@ public string createRegisterReport(string requestID, string venID, Dictionary<st
request.requestID = requestID;
request.venID = venID;

// Test case R1_3170_TH_VTN_1 (test-harness for OpenADR certification
// as provided by Quality logic) fails if reportRequestID is not set.
// Report request ID is mandatory in OpenADR for any subsquent request
// when sent for same report.
if (reportRequestID != null)
{
request.reportRequestID = reportRequestID;
}

request.oadrReport = new oadrReportType[reports.Count];

int index = 0;
Expand Down
4 changes: 3 additions & 1 deletion oadrlib/lib/oadr2b/ReportWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,9 @@ public oadrReportType generateReport(string reportRequestID)
return report;

List<IntervalType> reportIntervals = m_reportIntervals.Values.ToList().OrderBy(o => o.dtstart.datetime).ToList();
reportIntervals.Reverse();
// Test Case R1_3160_TH_VTN_1: Based on OpenADR specifications, intervals have to be
// in ascending order. Reversing it here converts it into descending order.
//reportIntervals.Reverse();

// the dtstart of the report must match the dtstart of the first interval
report.dtstart = new dtstart();
Expand Down