A (very) simple Playwright test driven by jenkins#357
Open
A (very) simple Playwright test driven by jenkins#357
Conversation
…hings more easily, but generally because if we're going to have labels they might as well be correct and useful.
…ncluding testing of lots nad lots of authors
…r checkboxes added instead of links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://ci-dev.eprints-hosting.org:8080/job/EPrints-3.5-Playwright/
I'd like to keep our ci code in the same repo as EPrints. This way old branches have old tests. If we ever need to fix something on an old release we can use old tests. Test and code cannot get out of sync.
There is nothing in here that's private to EPrints Services, all credentials are configured directly in secure storage on Jenkins itself. In theory anyone could set up their own jenkins instance and get this working - but I've put an explicit line at the top of the README that we will not support that.
The pytests themselves are probably what we should point people at if they really want to run tests themselves.
This requires Issue #355 fixed (hence branches off that branch) for the tests to work.
Because of the number of badly commented commits while testing jenkins I suggest this is squash-merged.