[Tests] Add 100-mutable pause/unpause gas regression coverage#162
[Tests] Add 100-mutable pause/unpause gas regression coverage#162equilibria0 merged 2 commits intomasterfrom
Conversation
Slither reportStatic Analysis Report**THIS CHECKLIST IS NOT COMPLETE**. Use `--show-ignored-findings` to show all the results. Summary - [locked-ether](#locked-ether) (1 results) (Medium) - [reentrancy-no-eth](#reentrancy-no-eth) (3 results) (Medium) - [unused-return](#unused-return) (9 results) (Medium) - [incorrect-modifier](#incorrect-modifier) (1 results) (Low) - [calls-loop](#calls-loop) (2 results) (Low) - [reentrancy-benign](#reentrancy-benign) (3 results) (Low) - [reentrancy-events](#reentrancy-events) (4 results) (Low) - [dead-code](#dead-code) (44 results) (Informational) - [solc-version](#solc-version) (3 results) (Informational) - [missing-inheritance](#missing-inheritance) (2 results) (Informational) - [naming-convention](#naming-convention) (13 results) (Informational) - [unimplemented-functions](#unimplemented-functions) (4 results) (Informational) - [unindexed-event-address](#unindexed-event-address) (1 results) (Informational) ## locked-ether Impact: Medium Confidence: High - [ ] ID-0 Contract locking ether found: Contract [MutablePauseTarget](https://github.com/equilibria-xyz/root/blob/32bc89927bf2ffd7451972f4b790fa739f2880c7/src/mutability/Mutable.sol#L138-L143) has payable functions: - [MutablePauseTarget.fallback()](https://github.com/equilibria-xyz/root/blob/32bc89927bf2ffd7451972f4b790fa739f2880c7/src/mutability/Mutable.sol#L139-L141) But does not have a function to withdraw the etherreentrancy-no-ethImpact: Medium
root/src/mutability/Mutator.sol Lines 34 to 46 in 32bc899
root/src/mutability/Mutable.sol Lines 123 to 127 in 32bc899
root/src/mutability/Mutable.sol Lines 97 to 113 in 32bc899 unused-returnImpact: Medium
root/src/token/types/Token6.sol Lines 43 to 45 in 32bc899
root/src/distribution/Airdrop.sol Lines 46 to 51 in 32bc899
root/src/token/types/Token.sol Lines 51 to 53 in 32bc899
root/src/token/types/Token18.sol Lines 53 to 55 in 32bc899
root/src/token/types/Token6.sol Lines 54 to 56 in 32bc899
root/src/distribution/Airdrop.sol Lines 28 to 34 in 32bc899
root/src/token/types/Token.sol Lines 40 to 42 in 32bc899
root/src/mutability/Mutator.sol Lines 34 to 46 in 32bc899
root/src/token/types/Token18.sol Lines 43 to 45 in 32bc899 incorrect-modifierImpact: Low
root/src/attribute/Attribute.sol Lines 28 to 32 in 32bc899 calls-loopImpact: Low
root/src/mutability/Mutator.sol Lines 62 to 65 in 32bc899
root/src/mutability/Mutator.sol Lines 57 to 60 in 32bc899 reentrancy-benignImpact: Low
root/src/mutability/Mutator.sol Lines 57 to 60 in 32bc899
root/src/mutability/Mutator.sol Lines 62 to 65 in 32bc899
root/src/mutability/Mutator.sol Lines 34 to 46 in 32bc899 reentrancy-eventsImpact: Low
root/src/mutability/Mutable.sol Lines 116 to 120 in 32bc899
root/src/mutability/Mutator.sol Lines 62 to 65 in 32bc899
root/src/mutability/Mutable.sol Lines 123 to 127 in 32bc899
root/src/mutability/Mutator.sol Lines 57 to 60 in 32bc899 dead-codeImpact: Informational
root/src/number/types/UFixed18.sol Lines 288 to 290 in 32bc899
root/src/number/types/Fixed6.sol Lines 295 to 297 in 32bc899
root/src/number/types/UFixed6.sol Lines 295 to 297 in 32bc899
root/src/number/types/Fixed6.sol Lines 287 to 289 in 32bc899
root/src/mutability/Implementation.sol Lines 66 to 68 in 32bc899
root/src/number/types/Fixed18.sol Lines 288 to 290 in 32bc899
root/src/number/types/Fixed6.sol Lines 311 to 313 in 32bc899
root/src/number/types/Fixed6.sol Lines 327 to 329 in 32bc899
root/src/number/types/UFixed6.sol Lines 311 to 314 in 32bc899
root/src/number/types/Fixed6.sol Lines 335 to 337 in 32bc899
root/src/number/types/Fixed18.sol Lines 304 to 306 in 32bc899
root/src/number/types/Fixed6.sol Lines 343 to 346 in 32bc899
root/src/number/types/UFixed18.sol Lines 313 to 316 in 32bc899
root/src/number/types/UFixed18.sol Lines 280 to 282 in 32bc899
root/src/number/types/UFixed6.sol Lines 329 to 331 in 32bc899
root/src/number/types/Fixed18.sol Lines 280 to 282 in 32bc899
root/src/number/types/Fixed6.sol Lines 303 to 305 in 32bc899
root/src/number/types/Fixed6.sol Lines 361 to 363 in 32bc899
root/src/number/types/UFixed6.sol Lines 279 to 281 in 32bc899
root/src/number/types/Fixed6.sol Lines 369 to 371 in 32bc899
root/src/number/types/UFixed18.sol Lines 330 to 332 in 32bc899
root/src/number/types/UFixed18.sol Lines 272 to 274 in 32bc899
root/src/number/types/Fixed6.sol Lines 352 to 355 in 32bc899
root/src/number/types/Fixed6.sol Lines 319 to 321 in 32bc899
root/src/number/types/UFixed18.sol Lines 296 to 298 in 32bc899
root/src/mutability/Implementation.sol Lines 71 to 73 in 32bc899
root/src/number/types/Fixed18.sol Lines 312 to 314 in 32bc899
root/src/number/types/UFixed6.sol Lines 320 to 323 in 32bc899
root/src/number/types/Fixed18.sol Lines 345 to 348 in 32bc899
root/src/number/types/Fixed18.sol Lines 336 to 339 in 32bc899
root/src/number/types/Fixed18.sol Lines 362 to 364 in 32bc899
root/src/number/types/Fixed18.sol Lines 320 to 322 in 32bc899
root/src/number/types/UFixed18.sol Lines 264 to 266 in 32bc899
root/src/number/types/UFixed6.sol Lines 303 to 305 in 32bc899
root/src/number/types/UFixed18.sol Lines 304 to 307 in 32bc899
root/src/number/types/UFixed18.sol Lines 322 to 324 in 32bc899
root/src/number/types/UFixed6.sol Lines 271 to 273 in 32bc899
root/src/number/types/UFixed6.sol Lines 263 to 265 in 32bc899
root/src/number/types/Fixed18.sol Lines 296 to 298 in 32bc899
root/src/number/types/Fixed18.sol Lines 354 to 356 in 32bc899
root/src/number/types/UFixed6.sol Lines 337 to 339 in 32bc899
root/src/number/types/UFixed6.sol Lines 287 to 289 in 32bc899
root/src/number/types/UFixed18.sol Lines 256 to 258 in 32bc899
root/src/number/types/Fixed18.sol Lines 328 to 330 in 32bc899 solc-versionImpact: Informational
root/src/attribute/Attribute.sol Line 2 in 32bc899
root/src/number/types/Fixed18.sol Line 2 in 32bc899
root/src/vrgda/VRGDADecayMath.sol Line 2 in 32bc899 missing-inheritanceImpact: Informational
root/src/utils/OwnableStub.sol Lines 9 to 15 in 32bc899
naming-conventionImpact: Informational
root/src/attribute/Pausable.sol Lines 34 to 36 in 32bc899
root/src/mutability/Mutable.sol Lines 37 to 41 in 32bc899
root/src/mutability/Mutable.sol Line 34 in 32bc899
root/src/attribute/Ownable.sol Line 21 in 32bc899
root/src/attribute/Ownable.sol Lines 42 to 44 in 32bc899
root/src/mutability/Implementation.sol Line 21 in 32bc899
root/src/attribute/Ownable.sol Lines 24 to 28 in 32bc899
root/src/mutability/Implementation.sol Lines 24 to 28 in 32bc899
root/src/attribute/Pausable.sol Line 23 in 32bc899
root/src/attribute/Pausable.sol Lines 26 to 30 in 32bc899
root/src/mutability/Implementation.sol Line 76 in 32bc899
root/src/attribute/Attribute.sol Lines 20 to 24 in 32bc899
root/src/attribute/Attribute.sol Line 17 in 32bc899 unimplemented-functionsImpact: Informational
root/src/attribute/Withdrawable.sol Lines 11 to 18 in 32bc899
root/src/mutability/Implementation.sol Lines 13 to 77 in 32bc899
root/src/attribute/Delegatable.sol Lines 12 to 20 in 32bc899
root/src/attribute/Executable.sol Lines 12 to 21 in 32bc899 unindexed-event-addressImpact: Informational
|
| vm.stopPrank(); | ||
|
|
||
| address[] memory mutables = mutator.mutables(); | ||
| assertEq(mutables.length, 100, "Expected 100 mutables"); |
There was a problem hiding this comment.
This test only creates 99 mutables while 1 was already being created in setUp(). Although the test focuses on checking pause/unpause gas, it might be good to add a comment for the mutables created.
prateekdefi
left a comment
There was a problem hiding this comment.
lgtm. Just one comment
Unit Test Coverage ReportCoverage after merging sec-f2-pause-scale-regression-test into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Security report
What was reviewed
Global pause/unpause iterates all mutables by design. This was considered expected behavior, but lacked a scale regression guard.
What was added
test_pauseUnpauseScalesToHundredMutables.Validation
forge test --match-path 'test/mutability/Mutator.t.sol' --match-test 'test_pauseUnpauseScalesToHundredMutables'forge test --match-path 'test/mutability/*.sol'Impact
Adds an explicit performance safety rail for operator workflows without changing production logic.
Note
Low Risk
Test-only change that adds a gas/performance guardrail for pause/unpause behavior; no production logic is modified.
Overview
Adds a new regression test (
test_pauseUnpauseScalesToHundredMutables) that provisions 100 mutables, then measuresmutator.pause()/mutator.unpause()gas usage and enforces a 4,000,000 gas budget for each.The test also asserts that global pause actually blocks calls on a mutable (expects
PausedError), providing scale/performance coverage without changing production contracts.Written by Cursor Bugbot for commit 8bd514a. This will update automatically on new commits. Configure here.