Skip to content

fix(uikit): Fix cell refs FRT-5738 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laniakea42 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(uikit): Fix cell refs FRT-5738 #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66e86c1
fix(uikit): Fix cell refs FRT-5738
laniakea42 Feb 26, 2024
cc6c783
fix(uikit): Fix cell refs FRT-5738-2
laniakea42 Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/cell/styled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const CellWrapper = styled.div`
justify-content: space-between;
align-items: center;
flex-shrink: 0;
gap: ${cssVar("--spacing-space-16")};
gap: ${cssVar("--spacing-space-12")};
font-size: 16px;
line-height: 23px;
letter-spacing: 0.16px;
Expand Down
34 changes: 13 additions & 21 deletions stories/cell.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,6 @@ export const Common: Story = {
render: () => {
return (
<CardStoryWrapper>
<Cell>
<Thumbnail md>{icon}</Thumbnail>
<CellItem clearMargin label={title}>
{underTitle}
</CellItem>
<CellItem reverse label={value}>
{underValue}
</CellItem>
</Cell>

<Cell>
<Thumbnail md>{icon}</Thumbnail>
<CellItem clearMargin label={title}>
Expand All @@ -54,14 +44,6 @@ export const Common: Story = {
<CellItem label={value}>{underValue}</CellItem>
</Cell>

<Cell>
<Thumbnail md>{icon}</Thumbnail>
<CellItem clearMargin label={underTitle}>
{title}
</CellItem>
<CellItem label={underValue}>{value}</CellItem>
</Cell>

<Cell>
<Thumbnail md>{icon}</Thumbnail>
<CellItem clearMargin>{title}</CellItem>
Expand All @@ -82,8 +64,8 @@ export const Common: Story = {

<Cell>
<Thumbnail md>{icon}</Thumbnail>
<CellItem clearMargin label={title}>
{underTitle}
<CellItem clearMargin reverse label="Caption">
{title}
</CellItem>
<CellItem>
<Label accent md className={cn(Class.M, Class.Accent)}>
Expand All @@ -92,6 +74,16 @@ export const Common: Story = {
</CellItem>
</Cell>

<Cell>
<Thumbnail md>{icon}</Thumbnail>
<CellItem clearMargin reverse label="Caption">
{title}
</CellItem>
<CellItem reverse label="Caption">
{value}
</CellItem>
</Cell>

<Cell>
<Thumbnail md>{icon}</Thumbnail>
<CellItem clearMargin>{title}</CellItem>
Expand Down Expand Up @@ -236,7 +228,7 @@ export const Common: Story = {
{underTitle}
</CellItem>
<CellItem>
<Checkmark style={{ width: "24px" }} />c
<Checkmark style={{ width: "24px" }} />
</CellItem>
</Cell>

Expand Down