Open
Conversation
Contributor
|
Don't we have admin access anyways? |
Contributor
Author
|
I mean, this is not strictly needed, but after manually typing all job names to required checks I thought it's nice to have. Admin access comes and goes + this is declarative and makes required stuff reviewable. No hard feelings however |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an aggregated job for required checks. This would be the only check required in github branch settings, allowing us to control which checks are needed to pass directly from the yaml. Currently all checks need to be added by hand to the settings, requiring admin access, instead of just from a PR