refactor(validator): move the validator itself to its own crate#3343
Open
refactor(validator): move the validator itself to its own crate#3343
Conversation
t00ts
force-pushed
the
t00ts/decouple-validator
branch
from
2ffd25f to
8ac8250
Compare
zvolin
approved these changes
Apr 15, 2026
| /// Used only for testing and dummy proposal creation. | ||
| #[cfg(any(test, feature = "p2p"))] | ||
| pub(crate) fn skip_validation( | ||
| pub fn skip_validation( |
Contributor
There was a problem hiding this comment.
I used to hide such code behind some test-utils features, to guarantee they don't end up being used in prod, but no hard feelings about that, if you already use different conventions
Contributor
Author
There was a problem hiding this comment.
It's a good point, I agree.
Dug deeper into this and the validator decoupling has exposed the current messy nature of our p2p flag, which I'm looking into right now and might eventually roll this back. But for now here it is 1af075c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3333