This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Rename the UI driver for Equinix Metal#33
Merged
displague merged 13 commits intoequinix:masterfrom Aug 24, 2021
Merged
Conversation
…n number in Makefile, and updates README Signed-off-by: Joseph D. Marhee <jmarhee@interiorae.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
It would be better to use git tags as the source of truth. This is a step towards that by removing yet another standalone version. Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
…king) Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
The raw.githubusercontent.com domain can contain content from anyone. Reduce the attack surface area. Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com>
…audit fix Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Member
Author
|
I've been holding out for a release of rancher/ui that includes rancher/ui#4647 so we can pin to that release. But we may just want to pin to master for now. |
displague
changed the title
Member
Author
|
Version 2.5.9 of the UI includes the merged changes. |
This was
linked to
issues
Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #29
Renames this project to equinix/ui-driver-metal
These are some changes that I applied while looking into why the literal translation strings were being rendered.
I don't know how to get the component.js to include the translations (or if it would dynamically load them from yaml files stored in our static site with component.js). I've looked for examples of other ui-drivers using translations in the past, and recently, and I have not found anything.
Looking at Ember and Gulp docs alone:
In this PR the
intlEmber service is loaded, but nothing is being done with it yet. (I imagine we could load our local translations into the service somehow.)While looking into this, I discovered that the translations are not affected when using the
packetvariation, because these translations are already loaded into Rancher:From this, I noticed:
I'm not sure if these are older / disabled UI driver components, that are still being maintained to some degree, or if these files are the authoritative Packet UI in current Rancher installs. If the Packet driver is maintained within rancher/ui we should be able to proceed with #14 much easier.
In these changes, I updated the whitelist domains and the component URL. I do not think Tinkerbell.org needs to be used. Looking at our Rancher integration, I see that https://packethost.github.io/ui-driver-packet/1.0.2/component.js is used today.
I believe we could use the equinix.github.com/ui-driver-metal variation in the future and we may want to include that in the whitelist now.