Skip to content

Conversation

@jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Jan 12, 2026

This reverts commit f67ebd5.

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@jonathan-eq jonathan-eq self-assigned this Jan 12, 2026
@jonathan-eq jonathan-eq moved this to Ready for Review in SCOUT Jan 12, 2026
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@github-project-automation github-project-automation bot moved this from Ready for Review to Reviewed in SCOUT Jan 12, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.52%. Comparing base (58c219b) to head (f4fa3bf).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12623      +/-   ##
==========================================
- Coverage   90.54%   90.52%   -0.02%     
==========================================
  Files         435      435              
  Lines       30014    30014              
==========================================
- Hits        27175    27171       -4     
- Misses       2839     2843       +4     
Flag Coverage Δ
cli-tests 37.27% <ø> (ø)
gui-tests 68.68% <ø> (-0.04%) ⬇️
performance-and-unit-tests 73.88% <ø> (-0.02%) ⬇️
test 38.05% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathan-eq jonathan-eq merged commit 127ef22 into equinor:main Jan 12, 2026
34 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Jan 12, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 12, 2026

Merging this PR will not alter performance

✅ 22 untouched benchmarks


Comparing jonathan-eq:revert (f4fa3bf) with main (58c219b)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants