Skip to content

Remove Optional and Union type hint#1097

Merged
andchiind merged 1 commit intoequinor:mainfrom
andchiind:1090-type-hint
Apr 7, 2026
Merged

Remove Optional and Union type hint#1097
andchiind merged 1 commit intoequinor:mainfrom
andchiind:1090-type-hint

Conversation

@andchiind
Copy link
Copy Markdown
Contributor

@andchiind andchiind commented Feb 18, 2026

Closes #1090

Depends on #1085

This complies with the python best practise https://typing.python.org/en/latest/reference/best_practices.html#shorthand-syntax

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like logging, TODO, etc.
  • The PR has been tested locally
  • A test has been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that requires new issues
  • The changes do not introduce dead code as unused imports, functions etc.

@andchiind andchiind self-assigned this Feb 18, 2026
@andchiind andchiind added improvement Improvement to existing functionality python Pull requests that update python code labels Feb 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

This pull request has been automatically marked as stale due to inactivity.

@github-actions github-actions bot added the stale This issue or pull request already exists label Apr 4, 2026
@andchiind andchiind merged commit 9672200 into equinor:main Apr 7, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement to existing functionality python Pull requests that update python code stale This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use | instead of "Optional" and "Union" in type hints

2 participants