refactor epasswd stuff #922
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes bug 2669.
The logic for "insects do not need castles in deserts or swamps" was broken.
Add a message and don't pay for the failed spell.
Fixing the symptoms, not the cause, becasue I don't know how this happened.
Zauber sollen force benutzen, nicht level.
Fixing the E3 rules.lua test We no longer need pyramid, scarab, sphinx, pharao.
Old implementation was bad, using set_observer is better. Still missing a test, but improved the one for sp_viewreality, which is almost doing the same thing - adaptation should be easy. Fixes https://bugs.eressea.de/view.php?id=2684
English Style: can't or can not => cannot
add more messages add unit tests closes https://bugs.eressea.de/view.php?id=2684
spotting monsters from lighthouses
Eliminate RCF_INVISIBLE and the spell race.
Implement a working LOCALE command. OBS: Throws away any command that isn't easy to translate.
firewall has no roads or peasants.
make ship_ownernot test u->number, hope that wasn't important.
Neue Meldung für Konvois mit zu wenigen Kapitänen.
flying units may leave a ship on the ocean.
in e3, goblins cannot use two-handed weapons.
- try to avoid builtin identifiers (like id, file) as variable names - try to avoid bare except - refactor the logic that deals with opening sqlite3 vs. bare passwd-like files; this now resides completely in epasswd.py - add explicit _Faction type for epasswd
ennorehling
force-pushed
the
develop
branch
3 times, most recently
from
62cc513 to
11ce5a2
Compare
ennorehling
force-pushed
the
develop
branch
3 times, most recently
from
68db444 to
e61b8ad
Compare
ennorehling
force-pushed
the
develop
branch
2 times, most recently
from
3dfa0c4 to
5730779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files; this now resides completely in epasswd.py