CRMap #4
Closed
CRMap #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created nogoblins directory (going to rename it to template) - added template/ to .eleventyignore - added pagination to base layout - added author field - updated README file for Tutorial authors
crmap, crmap_rdetails and crmap_udetails are separate now; you may even create your own element manually option for map id, map without details, caption, map layer (Astralraum) refactored code to produce descriptions outside of the svg file
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive CR (Computer Report) map visualization system for displaying Eressea game reports as interactive SVG maps. The main addition is a new crmap shortcode that can render CR files as clickable maps with region and unit details.
- Adds a complete CR parsing and SVG rendering system with interactive tooltips and detail panels
- Implements pagination for tutorial overview pages
- Adds author attribution and improved semantic markup for blog posts
Reviewed Changes
Copilot reviewed 13 out of 246 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crs/crs.js | Core CR parsing and SVG map generation engine with shortcode implementations |
| crs/crs.css | Styling for CR map tooltips, unit lists, and interactive elements |
| crs/crs-passthrough.js | Client-side JavaScript for map interactivity and detail panels |
| goblins/index.njk | Updated semantic markup (article→section, h1→h2) and added page title |
| aquarians/index.njk | Same semantic markup updates as goblins |
| goblins/goblins.json | Added author metadata |
| aquarians/aquarians.json | Added author metadata |
| _includes/post-layout.njk | Added CR script inclusion, author display, and tags footer |
| _includes/base-layout.njk | Added dynamic title, CR CSS, and pagination navigation |
| css/site.css | Added styling for author tags, navigation lists, and comment formatting |
| README.md | Complete rewrite with tutorial authoring instructions and CR map usage |
| .eleventyignore | Added template directory exclusion |
| .eleventy.js | Integrated CR map functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- crid tracked by page, no global state - argument to to crmap is now always a JSON string - use of reg.id removed - use of unit.faction is fine - use of ellipsis is fine
Author
|
Review addressed; css/js only included if actually needed. |
Author
|
Two new features:
|
- show sections of the nr like the intro, events, a region, a unit - you can even display line ranges of arbitrary text files - with or without line numbers - see template/Auswertung_01.md for usage examples
package is not maintained fixed bug in directory mode fixed typos added "silent" option
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Der Shortcode crmap kann einen CR als SVG anzeigen, klickbar mit (teilweise) Regions- und Einheitsdetails.
Außerdem enthalten: