Changed the treatment of the debug option so that a port can be set in c...#84
Open
edsykes wants to merge 1 commit intoericclemmons:masterfrom
Open
Changed the treatment of the debug option so that a port can be set in c...#84edsykes wants to merge 1 commit intoericclemmons:masterfrom
edsykes wants to merge 1 commit intoericclemmons:masterfrom
Conversation
…n configuration from the grunt file
Collaborator
|
@ericclemmons LGTM 🌟 |
|
+1 .. this fix is very helpful for my multi-app setup |
Owner
|
I'm eager to merge this down, but I'm not quite...sure what it does? @edsykes Can you add an example of this in the project's
|
Author
|
will do - it will take me a few days to get to this. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...onfiguration from the grunt file
Hi eric,
while running multiple node apps and wanting to debug them, I found that I couldn't set a debug port through the configuration in the grunt file. After investigating I found that the grunt task doesn't pick up the port - just whether debug is set or not.
I couldn't see any tests for the debug settings - so wasn't sure where to put the test for this, or indeed how to test this. If you'd like a test, please suggest where to put it and perhaps how best to test it.
Ed