Revert: Keep Ubuntu version at 26.04 for Vulkan Docker build #54
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to read the contributing guidelines before submitting a PR
Description
This PR reverts the Ubuntu version change in
.devops/vulkan.Dockerfileback to 26.04 as requested by the maintainer.The original change attempted to fix the Vulkan Docker build failure by changing Ubuntu from 26.04 to 24.04, but per maintainer feedback, the fix should be implemented differently while staying on Ubuntu 26.04.
Related to the GitHub Actions docker workflow failure introduced in commit bc809e9.
Original prompt
This section details on the original issue you should resolve
<issue_title>Misc. bug: Vulkan docker build fails on github actions</issue_title>
<issue_description>### Name and Version
Version 7134
Operating systems
Linux
Which llama.cpp modules do you know to be affected?
Other (Please specify in the next section)
Command line
Problem description & steps to reproduce
Hello again! Last week I opened an issue concerning an issue with the vulkan docker build. The issue was resolved with this commit, thank you btw :). The fix was to update the ubuntu version with which the dockerfile was built. Since that commit, docker builds of the vulkan image have been failing on github actions. A quick glance at the error logs from the first unsuccessful build shows that numpy fails to build, most likely due to a missing C compiler. Given that ubuntu 26.04 has not been released yet, there may be a conflict with the build essentials used in the dockerfile.
Paging @ericcurtin as it seems relevant.
First Bad Commit
The first bad commit is the one that introduced the fix to the issue I opened previously, commit bc809e9.
Relevant log output