Desktop: fix macos clippy regression from #324#325
Merged
Conversation
Take RunEvent by reference in handle_run_event and convert the app.run closure to pass &event. Fixes the macos-latest clippy job introduced in #324: error: this argument is passed by value, but not consumed in the function body On Linux/Windows the non-macos variant uses _event which silenced the lint there; macOS used the owned form and tripped -D warnings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The macos-latest clippy job failed on main after #324 merged:
```
error: this argument is passed by value, but not consumed in the function body
= note: `-D clippy::needless-pass-by-value` implied by `-D warnings`
```
On Linux and Windows the `_event` parameter name (underscore-prefixed) silenced the lint, so only macos-latest noticed.
Fix
Take `&RunEvent` in `handle_run_event` (both `#[cfg(target_os = "macos")]` and the noop variant). Adjust `app.run` closure to pass the borrow.
Test plan
🤖 Generated with Claude Code