Skip to content

Conversation

@colophonemes
Copy link

Fix error thrown by using 'join' as a method of the metalsmith object, rather than as an object itself

Fix error thrown by using 'join' as a method of the metalsmith object, rather than as an object itself
@ericgj
Copy link
Owner

ericgj commented Jun 24, 2016

Thanks. The underlying issue is this thing was never updated from pre-1.0.0 metalsmith... I'm surprised it still works at all!

It looks like the API was changed from metalsmith.join to metalsmith.path in v1.0.0. It would be better to use that rather than straight path.join since it looks like metalsmith.path prepends the metalsmith working directory.

But that would mean testing it on a newer version of metalsmith and updating package.json. Would you be up for doing that? I'm afraid I don't use metalsmith much anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants