Open
Conversation
Owner
|
Thank you for this PR. I think it's a great add on to the library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great NLogViewer, has helped me a ton. My main problem was that I wanted the ability to view Exceptions in full detail which I have done in a simple way using a popup. When an Exception / Error is logged with the exception passed with the message, for example:
the NLogViewer will look the same, but the logged ListViewItem can be clicked on like so to open a popup and display the full exception:
The popup is closed using the red X or by clicking off of it. This helps debugging by displaying long and detailed errors in full.
My code also has one minor change that has the Message column wrap text so longer messages will not have to make the user scroll horizontally forever. This also allowed the Message column to fill the length of the screen when the screen is resized and gives the popup the same width as the NLogViewer. This change was to remove any unnecessary scrolling and to have the NLogViewer fit whatever width it was put into.
My examples have the LoggerName and Level columns removed but that was only because my program does not need to display them, these changes will still work with those columns in use.