refactor: remove dead code, process dict usage, fix shutdown#121
Merged
tsloughter merged 1 commit intoerleans:mainfrom Mar 16, 2026
Merged
refactor: remove dead code, process dict usage, fix shutdown#121tsloughter merged 1 commit intoerleans:mainfrom
tsloughter merged 1 commit intoerleans:mainfrom
Conversation
- Remove commented-out code blocks (requires_statement_description, portal_suspended, set_succeeded_or_within_failed_transaction). - Thread query through loop state instead of storing it in the process dictionary via put/get. The query is now carried in the parse_complete_with_params and parameter_description_with_params state tuples. - Increase connection shutdown timeout from 100ms to 5000ms to allow graceful connection close on slow networks.
Collaborator
|
Thanks for the historical cruft cleanup! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requires_statement_description,portal_suspended,set_succeeded_or_within_failed_transaction).put(query, Query)/get(query). The query is now carried in theparse_complete_with_paramsandparameter_description_with_paramsstate tuples.Test plan