Skip to content

refactor: remove dead code, process dict usage, fix shutdown#121

Merged
tsloughter merged 1 commit intoerleans:mainfrom
Taure:fix/cleanup-and-reliability
Mar 16, 2026
Merged

refactor: remove dead code, process dict usage, fix shutdown#121
tsloughter merged 1 commit intoerleans:mainfrom
Taure:fix/cleanup-and-reliability

Conversation

@Taure
Copy link
Copy Markdown
Contributor

@Taure Taure commented Mar 13, 2026

Summary

  • Remove commented-out code blocks (requires_statement_description, portal_suspended, set_succeeded_or_within_failed_transaction).
  • Thread query through loop state tuples instead of storing in process dictionary via put(query, Query) / get(query). The query is now carried in the parse_complete_with_params and parameter_description_with_params state tuples.
  • Increase connection shutdown timeout from 100ms to 5000ms to allow graceful connection close on slow networks.

Test plan

  • All 54 existing CT tests pass
  • xref clean
  • dialyzer clean

- Remove commented-out code blocks (requires_statement_description,
  portal_suspended, set_succeeded_or_within_failed_transaction).
- Thread query through loop state instead of storing it in the process
  dictionary via put/get. The query is now carried in the
  parse_complete_with_params and parameter_description_with_params
  state tuples.
- Increase connection shutdown timeout from 100ms to 5000ms to allow
  graceful connection close on slow networks.
@tsloughter
Copy link
Copy Markdown
Collaborator

Thanks for the historical cruft cleanup!

@tsloughter tsloughter merged commit 687bd32 into erleans:main Mar 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants