feat: support function as password for dynamic credentials#122
Merged
tsloughter merged 3 commits intoerleans:mainfrom Mar 17, 2026
Merged
feat: support function as password for dynamic credentials#122tsloughter merged 3 commits intoerleans:mainfrom
tsloughter merged 3 commits intoerleans:mainfrom
Conversation
Accept fun(() -> iodata()) as the password config value. The function is evaluated on each new connection, enabling rotating credentials like AWS IAM auth tokens. When stored in pool config, the fun prints as #Fun<...> in logs, preventing accidental password disclosure. Closes erleans#56 Closes erleans#117
tsloughter
approved these changes
Mar 16, 2026
Collaborator
|
Has a conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fun(() -> iodata())as the password config value#Fun<...>in logs, preventing accidental password disclosure in supervisor crash reportsThis is the ERLEF-recommended approach for keeping credentials out of logs.
Closes #56
Closes #117
Test plan
password_as_functiontest added to pgo_SUITE