Allow custom scrape API server#128
Open
papaschloss wants to merge 6 commits intoerlloyd:mainfrom
Open
Conversation
this lets you use an environment variable to change the API server for scraping from marvelcdb -- VITE_API_SERVER. It needs the VITE_ prefix or else it won't be exposed to the app. It leaves the default in place if the env var is not set.
should work fine as long as you've set PUBLIC_URL or NPM_CONFIG_HOMEPAGE
VITE_WS_PROTOCOL, DOMAIN, and PORT
VITE_CEREBRO_IMAGES_URL
Author
|
ping @erlloyd just want to bring this to your attention. It also has changes to support configuring all the URLs via environment variables, making it much more portable |
Author
|
hello? Would love to see this merged, or let me know what changes I need to make. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this lets you use an environment variable to change the API server for scraping from marvelcdb -- VITE_API_SERVER. Fixing my own issue
It needs the VITE_ prefix or else it won't be exposed to the app. It leaves the default in place if the env var is not set.