Remove Phoenix boilerplate and add MIT license#17
Merged
Conversation
This script would crash for anyone cloning the repo since the epub file is not tracked in the repository. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
The stock Phoenix template with the Phoenix logo and links to Phoenix docs is confusing for visitors to an RLM project. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
Previously logged the first 12 characters of the API key, which is excessive. Showing only the last 4 is the industry-standard pattern for confirming key presence without leaking material. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
PageController and PageHTML are not referenced in the router (/ uses RunListLive). The channel/0 helper in RLMWeb has no channels in the application. All are leftovers from the Phoenix project generator. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
No email functionality exists in the application. Swoosh, its Mailer module, all config entries across dev/test/prod/runtime, and the /dev/mailbox route were all leftovers from the Phoenix project generator. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
Adds concise module documentation to Endpoint, Router, RunListLive, RunDetailLive, and Telemetry so ExDoc generates meaningful entries. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
.envrc is a local direnv preference file. Tracking it sets a precedent for committing environment configuration that varies per developer. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
Adds changelog entries for all public-release prep changes. Also makes the pre-commit hook skip gracefully when mix is not installed (e.g., in CI or sandboxed environments) instead of blocking all commits. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
errantsky
force-pushed
the
claude/prepare-public-release-ORbvZ
branch
from
2bc1153 to
2dfdc17
Compare
Documents that RLM executes arbitrary LLM-generated code with full system access, so users understand the trust boundary before using it. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
Runs compile --warnings-as-errors, format --check-formatted, and test on push/PR to main. Uses erlef/setup-beam with Elixir 1.19 / OTP 27 and caches deps/_build by mix.lock hash. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
Review caught that CLAUDE.md still listed mailer.ex in the project structure tree, and RLMWeb's moduledoc still mentioned channels. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
The branded replacement page was created then deleted in the same PR, so the net effect is just removal of dead PageController code — already documented in the Removed section. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
These entries were left behind when the swoosh dependency was removed from mix.exs. Equivalent to running mix deps.unlock --unused. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
The Grep tool and sandbox rg() wrapper depend on ripgrep. Without it, the fallback grep only searches .ex/.exs files, causing 3 test failures on .txt test fixtures. https://claude.ai/code/session_017daBoFtwa5WXqz76HA671w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clean up unused Phoenix generator artifacts, remove email/mailer functionality, and add MIT license for open-source distribution. This PR removes dead code that would confuse new contributors and simplifies the project structure.
Key Changes
Removed
PageControllerandPageHTMLmodule — unused Phoenix generator leftoversdemo_run.exs— referenced missingpriv/foodlab.epubfile that would crash on cloneRLMWeb.Mailerand all Swoosh email configuration — no email functionality exists in the applicationRLMWeb.channel/0helper — no Phoenix channels used/dev/mailboxroute and related Swoosh configuration.envrcfile (added to.gitignorefor local direnv preferences)Added
Changed
...XXXX) instead of first 12 for better security@moduledoctoRLMWeb.Endpoint,RLMWeb.Router,RLMWeb.RunListLive,RLMWeb.RunDetailLive, andRLMWeb.Telemetrymixis unavailable (CI/sandboxed environments)mix.exsconfig/config.exs,config/dev.exs,config/prod.exs, andconfig/test.exsImplementation Details
mixis not in PATHhttps://claude.ai/code/session_017daBoFtwa5WXqz76HA671w