Do not sys.exit(2) when device is not found, retry instead#104
Open
helen-fornazier wants to merge 1 commit intoeschava:masterfrom
Open
Do not sys.exit(2) when device is not found, retry instead#104helen-fornazier wants to merge 1 commit intoeschava:masterfrom
helen-fornazier wants to merge 1 commit intoeschava:masterfrom
Conversation
Author
|
@eschava Hi, please, let me know what do you think |
If broadlink-mqtt starts to run before the broadlink device is up, it fails and it doesn't reconnect. This happens only in the first connection. Once connected, broadlink-mqtt handles disconection well. This behaviour is annoying when configuring broadlink-mqtt as a systemd service, since it will get an error and won't recover. So instead of exiting, just retry, letting the user to turn on the broadlink device, or turn off some devices in case multiple broadlinks were found, and the system will auto-connect without user intervention.
helen-fornazier
force-pushed
the
master
branch
from
c42f492 to
5ad369e
Compare
Owner
|
Looks good but I'd add a configurable number of retries. Agree? |
Author
|
Hi @eschava , thanks for taking a look. For my usecase it is not useful to add a limited number of retries, but sure, if you think it can be useful to others, we can add it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If broadlink-mqtt starts to run before the broadlink device is up, it
fails and it doesn't connect.
This happens only in the first connection. Once connected,
broadlink-mqtt handles disconnection well.
This behavior is annoying when configuring broadlink-mqtt as a systemd
service, since it will get an error and won't recover.
So instead of exiting, just retry, letting the user to turn on the
broadlink device, or turn off some devices in case multiple broadlinks
were found, and the system will auto-connect without user intervention.