Open
Conversation
Owner
|
Sorry, but why it was required to move all these files to data folder? |
Author
|
So it is possible to single mount that folder in docker, with the config and actions with newly recorded actions. |
tomcollis
approved these changes
Dec 31, 2019
tomcollis
left a comment
There was a problem hiding this comment.
These changes all look fine, and I would certainly prefer to run this as a docker container than just as a script on a Linux machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I moved the data, added Dockerfile, so it can work in my docker setup. Thanks!